I am now finished with reviewing this commit.
A couple of things are changed now.
A few classes should be reverted:
- All the XXXStream classes, there we need to add new constructors
- All the classes in the test package which just use the
MockInputStreamFactory (there
we either don't need to reset, or the we need an InputStreamFactory
which can reset
the resource input streams).
- BeamSearch class
- ParserEventStream classes
Additionally we should have a look at the peformance monitoring, and
ensure it is done consistently across the
tool classes.
The InputStreamFactory class needs an updated javadoc comment.
Jörn
On 02/06/2014 02:32 PM, [email protected] wrote:
Author: joern
Date: Thu Feb 6 13:32:42 2014
New Revision: 1565236
URL: http://svn.apache.org/r1565236
Log:
OPENNLP-600 Removed deprecated main method
Modified:
opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/namefind/NameFinderEventStream.java
Modified:
opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/namefind/NameFinderEventStream.java
URL:
http://svn.apache.org/viewvc/opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/namefind/NameFinderEventStream.java?rev=1565236&r1=1565235&r2=1565236&view=diff
==============================================================================
---
opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/namefind/NameFinderEventStream.java
(original)
+++
opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/namefind/NameFinderEventStream.java
Thu Feb 6 13:32:42 2014
@@ -143,18 +143,4 @@ public class NameFinderEventStream exten
return ac;
}
-
- // Will be removed soon!
- @Deprecated
- public static final void main(String[] args) throws java.io.IOException {
- if (args.length != 0) {
- System.err.println("Usage: NameFinderEventStream < training files");
- System.exit(1);
- }
- EventStream es = new NameFinderEventStream(new NameSampleDataStream(
- new PlainTextByLineStream(new
MockInputStreamFactory(System.in),"UTF-8")));
- while (es.hasNext()) {
- System.out.println(es.next());
- }
- }
}
