Yes, that is a nice change, can you open a jira issue for it and send me the PR?
Would like to include that. Jörn On Tue, Dec 13, 2016 at 1:41 PM, Jeffrey Zemerick <jzemer...@apache.org> wrote: > Hi everyone, > > I came across a TODO in GeneratorFactory.java to make > the TokenClassFeatureGenerator construction configurable. My cursory search > of the JIRA didn't show any related tasks. I presumed the configuration was > referring to the boolean generateWordAndClassFeature argument in the > constructor of TokenClassFeatureGenerator. I added the parameter to the XML > and pass that value to the constructor. If there is no parameter in the XML > it sets to `true` to maintain backward compatibility. A diff of my changes > can be seen at > https://github.com/apache/opennlp/compare/trunk...jzonthemtn: > TokenClassFeatureGenerator > . > > If this was still a valid "todo" item and the changes I made were what was > desired I can submit a patch or a pull request. > > Jeff >
