+1 binding

- signature
- complete test suit OK (except for Maxent QN config minor issue)
- package OK (except for the README minor issue)
- CLI tools OK

2017-01-22 18:41 GMT-02:00 Tommaso Teofili <[email protected]>:

> +1
>
> - checked sigs
> - build ok
> - license ok
>
> Regards,
> Tommaso
>
>
> Il giorno dom 22 gen 2017 alle ore 18:18 Joern Kottmann <
> [email protected]>
> ha scritto:
>
> > On Sat, 2017-01-21 at 21:09 -0500, Jeffrey Zemerick wrote:
> > > I went to the opennlp-distr/README for a summary of changes in 1.7.1
> > > but I
> > > think it is the same as it was for 1.7.0. Is that file typically
> > > updated
> > > for revision releases? The link at the bottom of the RELEASE_NOTES to
> > > the
> > > fixed JIRA issues is issuesFixed/jira-report.html. Minor stuff but
> > > thought
> > > I'd ask.
> > >
> > >
> >
> > Yes, this file should be updated. And usually we do this, just this
> > time we didn't, I think we should release anyway and if we have to do
> > RC 2 we can update it.
> >
> > There is also another minor thing with a test for maxent qn which is
> > not configured correctly.
> >
> > Anyway, beside that, which will be perfect in 1.7.2 I didn't know of
> > anything which would keep us from taking RC 1 for the 1.7.1 release, I
> > will have a more detailed look at it now.
> >
> > Jörn
> >
>

Reply via email to