+1 (binding) Successfully executed complete evaluation tests in source deliverable. Tried it with DKPro and after updating the Lemmatizer and Chunker usage there was two test failures that we could trace back to issues fixed in OPENNLP-125 and OPENNLP-989 that would affect evaluation results.
2017-05-18 10:08 GMT-03:00 Tommaso Teofili <[email protected]>: > +1 (binding) > > Regards, > Tommaso > > p.s.: > > +1 also to Bruno's side comments > > Il giorno gio 18 mag 2017 alle ore 12:43 Bruno P. Kinoshita > <[email protected]> ha scritto: > > > > > [ X ] +1 Release the packages as Apache OpenNLP 1.8.0 > > > > Not binding > > > > Side note: would be nice later to start fixing some issues found via > > FindBugs. Running `mvn clean findbugs:findbugs findbugs:gui` shows > several > > errors, some seem important, like using equals() for array objects (which > > will always be false). > > > > See > > > > > > https://github.com/apache/opennlp/blob/73c8e5b9d8e055fefb53f7f3c2487d > 05c9788c6a/opennlp-tools/src/main/java/opennlp/tools/util/ > TokenTag.java#L85 > > > > And > > > > > > > > https://github.com/apache/opennlp/blob/73c8e5b9d8e055fefb53f7f3c2487d > 05c9788c6a/opennlp-tools/src/main/java/opennlp/tools/util/featuregen/ > POSTaggerNameFeatureGenerator.java#L59 > > Plus other NullPointerException's that can be prevented, and other minor > > issues. Not blockers for the release though, IMO. > > > > Cheers > > Bruno > > > > > > ________________________________ > > From: Joern Kottmann <[email protected]> > > To: [email protected] > > Sent: Thursday, 18 May 2017 9:49 AM > > Subject: [VOTE] Apache OpenNLP 1.8.0 Release Candidate 3 > > > > > > > > The Apache OpenNLP PMC would like to call for a Vote on Apache OpenNLP > > > > 1.8.0 Release Candidate 3. > > > > > > The RC 3 distributables can be downloaded from here: > > > > https://repository.apache.org/content/repositories/orgapacheopennlp-101 > > > > 3/org/apache/opennlp/opennlp-distr/1.8.0/ > > > > > > The release was made from the Apache OpenNLP 1.8.0 tag at > > > > https://github.com/apache/opennlp/tree/opennlp-1.8.0 > > > > > > > > To use it in a maven build set the version for opennlp-tools or > > > > opennlp-uima to 1.8.0 and add the following URL to your settings.xml > > > > file: > > > > https://repository.apache.org/content/repositories/orgapacheopennlp-101 > > > > 3 > > > > > > > > The release was made using the OpenNLP release process, documented on > > > > the Wiki here: > > > > https://cwiki.apache.org/confluence/display/OPENNLP/Release+Process > > > > > > > > The release contains quite some changes, please refer to the contained > > > > issue list for details. > > > > > > > > Please vote on releasing these packages as Apache OpenNLP 1.8.0. The > > > > vote is open for at least the next 72 hours. > > > > > > > > Only votes from OpenNLP PMC are binding, but folks are welcome to check > > > > the release candidate and voice their approval or disapproval. The vote > > > > passes if at least three binding +1 votes are cast. > > > > > > > > [ ] +1 Release the packages as Apache OpenNLP 1.8.0 > > > > [ ] -1 Do not release the packages because... > > > > > > > > > > > > Thanks! > > > > > > Jörn > > > > > > P.S. Here is my +1. > > >
