kinow commented on a change in pull request #337:
URL: https://github.com/apache/opennlp/pull/337#discussion_r837801128
##########
File path:
opennlp-tools/src/main/java/opennlp/tools/tokenize/SimpleTokenizer.java
##########
@@ -101,4 +107,12 @@ else if (Character.isDigit(c)) {
}
return tokens.toArray(new Span[tokens.size()]);
}
+
+ private boolean isLineSeparator(char character) {
+ return character == Character.LINE_SEPARATOR || character ==
Character.LETTER_NUMBER;
+ }
+
+ public void setKeepNewLines(boolean keepNewLines) {
+ this.keepNewLines = keepNewLines;
+ }
Review comment:
Would it make sense to move this common part to the parent abstract
class? Can be done/discussed later too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
