mawiesne commented on code in PR #60: URL: https://github.com/apache/opennlp-sandbox/pull/60#discussion_r1082299994
########## mahout-addon/pom.xml: ########## @@ -21,40 +21,52 @@ <project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> <modelVersion>4.0.0</modelVersion> - + <parent> - <groupId>org.apache.opennlp</groupId> - <artifactId>opennlp</artifactId> - <version>1.6.0-SNAPSHOT</version> - <relativePath>../opennlp/pom.xml</relativePath> - </parent> - + <groupId>org.apache</groupId> + <artifactId>apache</artifactId> + <!-- TODO OPENNLP-1452 once this is resolved, move to 29 as well. --> + <version>18</version> + <relativePath /> + </parent> + <artifactId>mahout-addon</artifactId> + <version>2.1.1-SNAPSHOT</version> <packaging>jar</packaging> <name>Apache OpenNLP Mahout Addon</name> <dependencies> <dependency> <groupId>org.apache.opennlp</groupId> <artifactId>opennlp-tools</artifactId> - <version>1.6.0-SNAPSHOT</version> + <version>2.1.0</version> </dependency> - + <dependency> <groupId>org.apache.mahout</groupId> <artifactId>mahout-core</artifactId> - <version>0.8</version> + <version>0.9</version> </dependency> <dependency> <groupId>junit</groupId> <artifactId>junit</artifactId> + <version>4.13.1</version> Review Comment: Will be change to JUnit 5 anyway, once new sandbox parent pom lands. ########## mahout-addon/pom.xml: ########## @@ -21,40 +21,52 @@ <project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> <modelVersion>4.0.0</modelVersion> - + <parent> - <groupId>org.apache.opennlp</groupId> - <artifactId>opennlp</artifactId> - <version>1.6.0-SNAPSHOT</version> - <relativePath>../opennlp/pom.xml</relativePath> - </parent> - + <groupId>org.apache</groupId> + <artifactId>apache</artifactId> + <!-- TODO OPENNLP-1452 once this is resolved, move to 29 as well. --> + <version>18</version> + <relativePath /> + </parent> + <artifactId>mahout-addon</artifactId> + <version>2.1.1-SNAPSHOT</version> <packaging>jar</packaging> <name>Apache OpenNLP Mahout Addon</name> <dependencies> <dependency> <groupId>org.apache.opennlp</groupId> <artifactId>opennlp-tools</artifactId> - <version>1.6.0-SNAPSHOT</version> + <version>2.1.0</version> </dependency> - + <dependency> <groupId>org.apache.mahout</groupId> <artifactId>mahout-core</artifactId> - <version>0.8</version> + <version>0.9</version> </dependency> <dependency> <groupId>junit</groupId> <artifactId>junit</artifactId> + <version>4.13.1</version> Review Comment: Will be changed to JUnit 5 anyway, once new sandbox parent pom lands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
