kinow commented on code in PR #71:
URL: https://github.com/apache/opennlp-sandbox/pull/71#discussion_r1083414830
##########
opennlp-similarity/src/test/java/opennlp/tools/parse_thicket/apps/MultiSentenceSearchResultsProcessorTest.java:
##########
@@ -20,11 +20,18 @@
import opennlp.tools.similarity.apps.HitBase;
-import junit.framework.TestCase;
+import org.junit.Ignore;
+import org.junit.Test;
-public class MultiSentenceSearchResultsProcessorTest extends TestCase {
- MultiSentenceSearchResultsProcessor proc = new
MultiSentenceSearchResultsProcessor();
+import static org.junit.Assert.assertTrue;
+public class MultiSentenceSearchResultsProcessorTest {
+
+ private final MultiSentenceSearchResultsProcessor proc = new
MultiSentenceSearchResultsProcessor();
+
+ @Test
+ @Ignore
+ // This test case fails with: "UnknownHostException:
api.datamarket.azure.com: nodename nor servname provided, or not known"
Review Comment:
>@kinow Given
https://www.developer.com/news/microsoft-to-shut-down-azure-datamarket/ , it
seems time to drop those tests and related code.
>
>Nobody will ever benefit having this non-functional "garbage" laying around
in the sandbox.
Agreed.
>If you agree, I'd kick those parts out?
I think the only issue is if this is the only test coverage we have for that
part of the code. In that case, we'd probably need to mock things around, or
rethink the testing strategy - making it independent of external systems,
and/or having a separate suite for tests potentially brittle that depend on
external systems.
But not a blocker for this PR, can be done separately I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
