Richard, yes, it is possible that the values in the tests should be updated, and in this case that looks likely.
The affecting change is this: https://github.com/apache/opennlp/pull/442/files Both tests pass when that change is reverted. It looks to me the merged change is correct, and I think updating the values in the test assertions is appropriate. Any thoughts from anyone? Thanks, Jeff On Mon, Jan 30, 2023 at 9:20 AM Richard Zowalla <r...@apache.org> wrote: > Hi Jeff, > > Regarding ArvoresDeitadasEval.evalPortugueseChunkerQn(...): Higher > cross validation accuracy is a good thing, no? ;-) But it would be > interesting to know, why it is (a bit) better than before. > > Regarding SourceForgeModelEval.evalChunkerModel(...): > > Maybe just do a git bisect session? We have tests in place, so identify > ing the commit, which introduced the regression, should be quite simple > via git bisect? If we have the commit, we can see, what has changed and > find a solution for it. > > Gruß > Richard > > > Am Montag, dem 30.01.2023 um 09:05 -0500 schrieb Jeff Zemerick: > > Good catch, Bruno. I wrote the NOTICE file date up as > > https://issues.apache.org/jira/browse/OPENNLP-1458. > > > > I also noticed that the jira-report Maven plugin is throwing an NPE > > during > > the release build. This might explain why our list of Jira issues was > > empty > > in the release notes last time. The stack trace is in the Jira > > ticket: > > https://issues.apache.org/jira/browse/OPENNLP-1456 > > > > Lastly, there were two test failures in the eval-tests: > > > > [ERROR] Failures: > > [ERROR] > > ArvoresDeitadasEval.evalPortugueseChunkerQn:211->chunkerCrossEval:140 > > expected: <0.9648211936491359> but was: <0.9651009811896799> > > [ERROR] SourceForgeModelEval.evalChunkerModel:345 expected: > > <226003515785585284478071030961407561943> but was: > > <304922886851384639120257052245406261332> > > > > I re-ran these two tests in OpenNLP 2.1.0 and they both passed. So > > something seems to have changed to affect them in 2.1.1. I will > > investigate > > it more but if anyone remembers any changes that might have had an > > impact > > let me know! https://issues.apache.org/jira/browse/OPENNLP-1459 > > > > Because of these issues, let's cancel the vote for OpenNLP 2.1.1 RC1 > > until > > these issues (and any others that are found in the meantime) are > > resolved > > or mitigated. > > > > Thanks, > > Jeff > > > > > > On Sat, Jan 28, 2023 at 3:15 PM Bruno Kinoshita <ki...@apache.org> > > wrote: > > > > > Hi Jeff, > > > > > > I downloaded one of dist zip files to start verifying its files, > > > but > > > immediately noticed that the NOTICE file had the date to 2022. I > > > think it > > > needs to be updated to 2023? > > > > > > Cheers > > > Bruno > > > > > > On Sat, 28 Jan 2023 at 16:07, Jeff Zemerick <jzemer...@apache.org> > > > wrote: > > > > > > > Hi folks, > > > > > > > > I have posted a first release candidate for the Apache OpenNLP > > > > 2.1.1 > > > > release and it is ready for testing. > > > > > > > > There were 60 Jira issues addressed in this version. Most of > > > > these issues > > > > were improvements like code refactoring and unit tests. The full > > > > list is > > > > available in Jira at: > > > > > > > > > > > > https://issues.apache.org/jira/browse/OPENNLP-1452?jql=project%20%3D%20OPENNLP%20AND%20status%20%3D%20Closed%20AND%20fixVersion%20%3D%202.1.1%20ORDER%20BY%20created%20DESC > > > > The distributables can be downloaded from: > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheopennlp-1031/org/apache/opennlp/opennlp-distr/2.1.1/ > > > > The release was made from the Apache OpenNLP 2.1.1 tag at: > > > > https://github.com/apache/opennlp/tree/opennlp-2.1.1 > > > > > > > > To use it in a maven build set the version for opennlp-tools or > > > > opennlp-uima to 2.1.1 and add the following URL to your > > > > settings.xml > > > file: > > > > > https://repository.apache.org/content/repositories/orgapacheopennlp-1031 > > > > > > > > The release was made using the OpenNLP release process, > > > > documented on the > > > > website: > > > > https://opennlp.apache.org/release.html > > > > > > > > Please vote on releasing these packages as Apache OpenNLP 2.1.1. > > > > The vote > > > > is open for at least the next 72 hours. > > > > > > > > Only votes from OpenNLP PMC are binding, but everyone is welcome > > > > to check > > > > the release candidate and vote. > > > > The vote passes if at least three binding +1 votes are cast. > > > > > > > > [ ] +1 Release the packages as Apache OpenNLP 2.1.1 > > > > [ ] -1 Do not release the packages because... > > > > > > > > Thanks! > > > > Jeff > > > > > >
