rzo1 commented on code in PR #492:
URL: https://github.com/apache/opennlp/pull/492#discussion_r1116845737
##########
opennlp-tools/src/main/java/opennlp/tools/ml/maxent/GISTrainer.java:
##########
@@ -407,9 +399,9 @@ public GISModel trainModel(int iterations, DataIndexer di,
Prior modelPrior, int
prior.setLabels(outcomeLabels, predLabels);
numPreds = predLabels.length;
- display("\tNumber of Event Tokens: " + numUniqueEvents + "\n");
- display("\t Number of Outcomes: " + numOutcomes + "\n");
- display("\t Number of Predicates: " + numPreds + "\n");
+ logger.info("Number of Event Tokens: {}", numUniqueEvents);
Review Comment:
I will change it to a one-liner with \t formatting as before.
##########
opennlp-tools/src/main/java/opennlp/tools/ml/perceptron/PerceptronTrainer.java:
##########
@@ -265,25 +270,25 @@ public AbstractModel trainModel(int iterations,
DataIndexer di, int cutoff, bool
numPreds = predLabels.length;
numOutcomes = outcomeLabels.length;
- display("done.\n");
+ logger.info("done.");
- display("\tNumber of Event Tokens: " + numUniqueEvents + "\n");
- display("\t Number of Outcomes: " + numOutcomes + "\n");
- display("\t Number of Predicates: " + numPreds + "\n");
+ logger.info("Number of Event Tokens: {}", numUniqueEvents);
Review Comment:
done
##########
opennlp-tools/src/main/java/opennlp/tools/ml/naivebayes/NaiveBayesTrainer.java:
##########
@@ -145,17 +150,17 @@ public AbstractModel trainModel(DataIndexer di) {
numPreds = predLabels.length;
numOutcomes = outcomeLabels.length;
- display("done.\n");
+ logger.info("done.");
- display("\tNumber of Event Tokens: " + numUniqueEvents + "\n");
- display("\t Number of Outcomes: " + numOutcomes + "\n");
- display("\t Number of Predicates: " + numPreds + "\n");
+ logger.info("Number of Event Tokens: {}", numUniqueEvents);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
