rzo1 commented on code in PR #506:
URL: https://github.com/apache/opennlp/pull/506#discussion_r1118111204
##########
opennlp-tools/src/main/java/opennlp/tools/tokenize/lang/Factory.java:
##########
@@ -25,24 +25,45 @@
public class Factory {
- public static final String DEFAULT_ALPHANUMERIC = "^[A-Za-z0-9]+$";
+ public static final Pattern DEFAULT_ALPHANUMERIC =
Pattern.compile("^[A-Za-z0-9]+$");
Review Comment:
I am fine with the reasoning for keeping it public atm, but would prefer to
make it private in the long run (maybe via the `@Deprecated` approach as with
`alphaNumeric` before). 🙃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
