rzo1 commented on code in PR #553:
URL: https://github.com/apache/opennlp/pull/553#discussion_r1359516231


##########
opennlp-dl/src/test/java/opennlp/dl/doccat/DocumentCategorizerDLEval.java:
##########
@@ -92,6 +92,46 @@ public void categorize() throws IOException, OrtException {
 
   }
 
+  @Test
+  public void categorizeWithAutomaticLabels() throws IOException, OrtException 
{
+
+    final File model = new File(getOpennlpDataDir(),

Review Comment:
   No. In this configuration, it relies on a data directory, which must 
supplied via a `-DOPENNLP_DATA_DIR=PATH` parameter or system property value.
   
   There are other options used in OpenNLP as well:
   
   - 
https://github.com/apache/opennlp/blob/main/opennlp-tools/src/main/java/opennlp/tools/util/DownloadUtil.java#L126
 is used to download models. Models are cached in a local directory on disk
   - One could also rely on maven download plugin to download and cache locally.
   - 
https://github.com/apache/opennlp/blob/6fde608cb0dd5866c6330f3e3dcd04f791c4ef96/opennlp-tools/src/test/java/opennlp/tools/EnabledWhenCDNAvailable.java#L38
 only download stuff, if you are online
   
   I could also imagine, that one could build a special annotation to only 
download the model files, if you are in a CI/CD context in which it doesn't 
really matter, if additional 600mb are downloaded ;-)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to