mawiesne opened a new pull request, #600: URL: https://github.com/apache/opennlp/pull/600
Change - - adjusts TwoPassDataIndexer to make use of JDK's built-in `CheckedOutputStream` / `CheckedInputStream` for checksum ([CRC32c](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/zip/CRC32C.html)) computations - removes untested class `HashSumEventStream` which is just a wrapper for calling a slow toString() in Event to get some bytes to use for the computation of a checksum - provides a HashSumEventStream replacement: `ChecksumEventStream` which makes use of the faster CRC32c checksum computation, avoiding cryptographic hash functions such as MD5 - adds JUnit tests for ChecksumEventStream Note(s) - 1. A _full_ OpenNLP build is consistently about 3-4s faster on my local machine (61s vs. 57s => ~ -7%) . 2. The effect should be greater when processing large(r) training corpora. 3. We should see a difference in a bare metal EVAL build run. Tasks - Thank you for contributing to Apache OpenNLP. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
