mawiesne commented on code in PR #637:
URL: https://github.com/apache/opennlp/pull/637#discussion_r1677804022
##########
opennlp-tools/src/main/java/opennlp/tools/ml/maxent/GISModel.java:
##########
@@ -207,7 +206,7 @@ static double[] eval(Context[] context, float[] values,
double[] prior,
@Override
public int hashCode() {
Review Comment:
Yes, however in this case, I thought it might be better to leave it in,
'cause other devs can see clearer, both equals and hashCode are overridden.
Otherwise, in the future, some _bro_ or _sis_ might re-introduce a copy or a
bad implementation of hashCode() here again.
But if we want to stay "clean", I can remove it here as well. Wdyt @rzo1 /
@kinow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
