NishantShri4 commented on code in PR #758:
URL: https://github.com/apache/opennlp/pull/758#discussion_r2012774502
##########
opennlp-tools/src/main/java/opennlp/tools/ml/perceptron/PerceptronTrainer.java:
##########
@@ -257,15 +260,17 @@ public AbstractModel trainModel(int iterations,
DataIndexer di, int cutoff, bool
logger.info("Computing model parameters...");
- MutableContext[] finalParameters = findParameters(iterations, useAverage);
+
+ //@TODO : Ideally an instance of TrainingProgressMonitor will be
introduced via Trainer Factory.
+ MutableContext[] finalParameters = findParameters(iterations, useAverage,
new ConsoleTrainingProgressMonitor());
Review Comment:
Thanks.
1. Shall we include a progressMonitor and stopCriteria in
TrainingParameters?
2. Or else we create a new TrainingConfiguration entity ?
This embeds the two (i.e. TPM and StopCriteria) and is passed as an
argument to an overloaded getEventTrainer(..)
method
`
public static EventTrainer getEventTrainer(
TrainingParameters trainParams, Map<String, String> reportMap,
TrainingConfiguration config)
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
