mawiesne opened a new pull request, #786:
URL: https://github.com/apache/opennlp/pull/786
Prolog
-
**IMPORTANT**:
- ⚠️ The relocation of classes, test classes and resources are
substantial!
- ❕ **DO NOT** try to read the DIFF here on GH.
- 👨🏽🔧 Instead, checkout the branch locally, switch to it and run a
- `mvn clean install` and
- inspect the module structure and internal dependencies.
- 🚧 This is work in progress and shall demonstrate the new modular
structure. Force pushes might change the PR as some some remainder cleanup work
is to be done.
Changes
-
- defines new Maven module hierarchy
- resolves OPENNLP-1709 (API)
- resolves OPENNLP-1710 (Core)
- resolves OPENNLP-1711 (CLI)
- resolves OPENNLP-1712 (Tools)
- resolves OPENNLP-1713 (Extensions)
- resolves OPENNLP-1717 (API in core/dl)
- resolves OPENNLP-1718 (API, RT, etc. in uima & morfologik)
Notes
-
- Tests separated, all passing!
- `opennlp-ml` module is just a stub for now and can / will be filled next.
Tasks
-
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
