NishantShri4 commented on code in PR #792:
URL: https://github.com/apache/opennlp/pull/792#discussion_r2164677508
##########
opennlp-core/opennlp-runtime/src/test/java/opennlp/tools/sentdetect/SentenceDetectorMEGermanTest.java:
##########
@@ -45,19 +48,25 @@ public class SentenceDetectorMEGermanTest extends
AbstractSentenceDetectorTest {
private static SentenceModel sentdetectModel;
- @BeforeAll
- public static void prepareResources() throws IOException {
- Dictionary abbreviationDict = loadAbbDictionary(Locale.GERMAN);
- SentenceDetectorFactory factory = new SentenceDetectorFactory(
- "deu", true, abbreviationDict, EOS_CHARS);
- sentdetectModel = train(factory, Locale.GERMAN);
- Assertions.assertNotNull(sentdetectModel);
- Assertions.assertEquals("deu", sentdetectModel.getLanguage());
+ private void prepareResources(boolean useTokenEnd) {
+ try {
+ Dictionary abbreviationDict = loadAbbDictionary(Locale.GERMAN);
Review Comment:
Thanks. This is done.
##########
opennlp-core/opennlp-runtime/src/test/java/opennlp/tools/sentdetect/SentenceDetectorMEGermanTest.java:
##########
@@ -45,19 +48,25 @@ public class SentenceDetectorMEGermanTest extends
AbstractSentenceDetectorTest {
private static SentenceModel sentdetectModel;
Review Comment:
Thanks this is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
