krickert commented on PR #1003: URL: https://github.com/apache/opennlp/pull/1003#issuecomment-4221478469
OK - the tests didn't catch it but there was one more part that needed extra thread safe work: `POSTaggerME`, `TokenizerME`, `SentenceDetectorME`, `ChunkerME`, `LemmatizerME`, and `NameFinderME` kept last-decode state in ordinary instance fields for the first caller, so concurrent `probs()` / “last run” access could race or observe another thread’s results. They only moved that state into ThreadLocal after a second thread touched the same instance, which made the bug easy to miss. I'll post the fix and describe the solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
