Copilot commented on code in PR #1072:
URL: https://github.com/apache/opennlp/pull/1072#discussion_r3388727588
##########
opennlp-eval-tests/src/test/java/opennlp/dl/vectors/SentenceVectorsDLEval.java:
##########
@@ -38,9 +38,9 @@ public void generateVectorsTest() throws Exception {
final float[] vectors = sv.getVectors(sentence);
- Assertions.assertEquals(vectors[0], 0.39994872, 0.00001);
- Assertions.assertEquals(vectors[1], -0.055101186, 0.00001);
- Assertions.assertEquals(vectors[2], 0.2817594, 0.00001);
+ Assertions.assertEquals(vectors[0], 0.044745024, 0.00001);
+ Assertions.assertEquals(vectors[1], 0.20219636, 0.00001);
+ Assertions.assertEquals(vectors[2], 0.41306049, 0.00001);
Assertions.assertEquals(vectors.length, 384);
Review Comment:
The JUnit `assertEquals` calls have the `expected` and `actual` arguments
reversed here, which makes failure messages misleading. Swap the parameters so
the pinned constants are the expected values and the computed vector entries
are the actual values (same for the length check).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
