krickert opened a new pull request, #1083: URL: https://github.com/apache/opennlp/pull/1083
## What Adds `<skip>false</skip>` to the surefire configuration of the `eval-tests` and `high-memory-tests` profiles in `opennlp-eval-tests`. ## Why See [OPENNLP-1843](https://issues.apache.org/jira/browse/OPENNLP-1843). The module's base build sets surefire `skip=true` and the profiles never override it, so Maven's configuration merge leaves the skip in effect: the module compiles its eval sources and executes zero tests, even with `-Peval-tests`. Every eval class in the module is affected. Visible in eval-tests-configurable build #48, where the module section shows only compilation (~1.2s) and no `*Eval` class appears in the console log. ## Validation Reproduced locally: on current `main`, `mvn -pl opennlp-eval-tests -Peval-tests test` completes in ~1.5s running nothing. With the fix, the evals execute (verified with the nightlies eval data: SentenceVectorsDLEval, NameFinderDLEval and DocumentCategorizerDLEval all run) and fail loudly when `OPENNLP_DATA_DIR` is unset instead of being skipped silently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
