krickert commented on PR #1104: URL: https://github.com/apache/opennlp/pull/1104#issuecomment-4763073511
**Term.at() ordering footgun.** Fixed by documentation: `at()`'s javadoc now states that an unconfigured dimension is applied on top of `normalized()` (the most aggressive configured layer) rather than spliced into canonical pipeline order, and gives a concrete non-commutative example (case-fold over accent-fold). Callers who need canonical order configure the dimension on the analyzer. Sound good? **WordType.IDEOGRAPHIC javadoc overstates.** Fixed. Reworded to "a token containing a Han ideograph (one ideograph per token under UAX #29 segmentation)". **WordTokenizer implements Tokenizer directly.** Fixed. Added a comment explaining the deliberate choice: it produces spans from the UAX #29 segmenter in one pass and shares none of `AbstractTokenizer`'s per-character probability/merge machinery, so subclassing it would only add unused state. **Nit: IntList capacity doubling overflow.** Fixed. `IntList` now grows overflow-aware (1.5x, clamped to `Integer.MAX_VALUE - 8`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
