rzo1 commented on PR #1106:
URL: https://github.com/apache/opennlp/pull/1106#issuecomment-4799034781

   - `normalizer.xml` and the modified `tokenizer.xml` use `xlink:href` without 
declaring `xmlns:xlink` on the chapter root, unlike the other xlink-using 
chapters (e.g. `chunker.xml`). It still builds (the DocBook DTD declares it 
`#FIXED`), but add `xmlns:xlink` for convention.
   - The second `namefinder.xml` ONNX snippet uses an empty `ids2Labels` map, 
which would throw `IllegalStateException` at runtime and contradicts the 
surrounding warning that the map must be exhaustive. Mirror the populated BIO 
map from the first snippet.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to