Thank you. That's good news.
Sure, feel free to merge it to other branches. I've also added it to https://wiki.openoffice.org/wiki/Building_old_versions Regards Damjan On Sun, Jul 28, 2019 at 12:12 PM Matthias Seidel <matthias.sei...@hamburg.de> wrote: > Hi Damjan, > > Am 28.07.19 um 07:32 schrieb Damjan Jovanovic: > > For AdoptOpenJDK it was config files and several .cxx files that register > > Java implementations (we really should extract that from config files > > instead). > > > > For Java 11/12 it was .cxx files that specify search paths for libjvm.so > on > > *nix. Yes, there may still be issues on Windows/Mac/etc. > > Well done! > > I can confirm that "OpenJDK8U-jre_x86-32_windows_hotspot_8u222b10" is > detected on Windows with your latest changes! > > That should be merged to AOO42X and maybe it is a candidate for AOO417? > Opinions? > > Regards, > > Matthias > > > > > On Sun, Jul 28, 2019 at 5:31 AM Peter Kovacs <pe...@apache.org> wrote: > > > >> Should we not move this stuff in some sort of config file?Is the > >> information in the config file you edited? > >> > >> On 27.07.19 21:52, Damjan Jovanovic wrote: > >>> Thank you. > >>> > >>> I've added the new paths in commit 1863883. > >>> > >>> Regards > >>> Damjan > >>> > >>> > >>> On Sat, Jul 27, 2019 at 8:39 PM Mechtilde <o...@mechtilde.de> wrote: > >>> > >>>> Hello Damjan, > >>>> > >>>> here you can see the paths of the different Java versions fpr > libjvm.so > >>>> under Debian: > >>>> > >>>> /usr/lib/jvm/java-11-openjdk-amd64/lib/server/libjvm.so > >>>> /usr/lib/jvm/java-12-openjdk-amd64/lib/server/libjvm.so > >>>> /usr/lib/jvm/java-8-openjdk-amd64/jre/lib/amd64/server/libjvm.so > >>>> > >>>> Kind regards > >>>> > >>>> > >>>> Am 27.07.19 um 20:18 schrieb Damjan Jovanovic: > >>>>> The problem with AdoptOpenJDK 11 is that it has a: > >>>>> lib/server/libjvm.so > >>>>> instead of the expected: > >>>>> lib/amd64/server/libjvm.so > >>>>> > >>>>> Patching AOO to search the new path fixes the detection problem. > >>>>> > >>>>> Does OpenJDK 11 / Oracle JDK 11 have the same change in path? Those > >>>> require > >>>>> a different patch. > >>>>> > >>>>> Regards > >>>>> Damjan > >>>>> > >>>> -- > >>>> Mechtilde Stehmann > >>>> ## Apache OpenOffice > >>>> ## Freie Office Suite für Linux, MacOSX, Windows > >>>> ## Debian Developer > >>>> ## PGP encryption welcome > >>>> ## F0E3 7F3D C87A 4998 2899 39E7 F287 7BBA 141A AD7F > >>>> > >>>> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > >> For additional commands, e-mail: dev-h...@openoffice.apache.org > >> > >> > >
