Greetings,

File svl/source/misc/inettype.cxx defines function seekEntry,
which does a binary search on an array of MediaTypeEntry passed
as its second argument.  In a non-production build, it verifies
that the passed array is in sequence by (since cws sb121) value
of m_pTypeName.  I take this sequence verification to be a
protection against an editing error in the maintenance of the
arrays of constants defined in the file.

If I am reading the code correctly, the function uses its static
bool bChecked to limit the sequence verification to the first
time it is called.  However, the verification would seem to be
good for all of the arrays of constants.  seekEntry is called
with three different arrays to search (aStaticTypeNameMap,
aStaticExtensionMap, aStaticPresentationMap).

Is this a problem?  Is it worth fixing?

Cheers,
Terry.



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to