On Fri, 2010-02-12 at 09:11 +0100, Frank Schoenheit, Sun Microsystems
Germany wrote:
> Hi,
>
> issue 109142 (http://www.openoffice.org/issues/show_bug.cgi?id=109142)
> requests to change the behavior of assertions (OSL_ASSERT/DBG_ASSERT and
> friends) to abort if their condition is not met. The current behavior is
> that the assertion text is reported to the user, usually by a message box.
> All of the above applies to non-product builds only, in particular, the
> request, as I understand it, is *not* to extend assertions to product
> builds.
>
> Since this is a controversial topic, I think we should discuss it in a
> wider audience before actually implementing the change - so, let's get
> the party started ...
Short version: Here is an example of an assertion which I whould not
want to see abort. Maybe it is an argument in favour of having
assertions of different severities.
Long version: I just managed to provoke ...
Error: Invalid MediaDescriptor detected:
Found no URL.
From
File
/home/terry/OOo_hacking/DEV300_m75/comphelper/source/misc/mediadescriptor.cxx
at Line 586
Abort ? (Yes=abort / No=ignore / Cancel=core dump)
The bit "Found no URL" sounds like an entirely fair discription of the
situation. (In Calc, I took External Data > Link to External Data ...;
in the dialog box External Data, for the field "URL of external data
source", I clicked the dropdown icon, decided I did not want to go
there, and clicked the dropdown icon again.)
Under the circumstatnces, if the assertion aborted, I would feel that OO
was punishing me severely for a trivial error. As it is, the message is
a small nuisance (And it would have been a really small nuisance if I
had bothered to actually read the message before I rushed off to
recreate the situation, carefully writing down each step along the way
<grin />.)
I suppose I should create an issue for this, just because the guidelines
say that every assertion failure should be raised as an issue. Still, I
shall hold off in case somebody cares to comment.
Cheers,
Terry.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
