On 30/07/2010 13:22, Bartosz wrote:
> Hi.
> I have created patch, which replace SV_DECL_PTRARR with std::vector.
>
> It is first step to resolve old bug:
> http://www.openoffice.org/issues/show_bug.cgi?id=84159
>
> Unfortunately this patch is not works correctly.
> After compile/run OpenOffice the application freeze.
>
> I do something wrog, but I cannot find bug which couse this freeze.
hi Bartosz,
if all else fails, you'll need to recompile the "svl" module with debug.
(build debug=t)
then copy the library into an OOo installation.
then attach a debugger to OOo, and the stack trace should show you where
it's looping.
> Here is patch prepared by me:
[snip]
> @@ -582,8 +575,8 @@
> {
> if ( *ppItemArr )
> {
> - SfxPoolItem** ppHtArr =
> (SfxPoolItem**)(*ppItemArr)->GetData();
> - for ( USHORT n = (*ppItemArr)->Count();
> n; --n, ++ppHtArr )
> + SfxPoolItem** ppHtArr =
> (SfxPoolItem**)(*ppItemArr);
> + for ( size_t n = (*ppItemArr)->size();
> n; --n, ++ppHtArr )
this looks suspicious: why can you replace ->GetData() with nothing?
why does this even compile?
(the same change is also in other places...)
--
"In the beginning the Universe was created. This has made a lot of
people very angry and been widely regarded as a bad move."
-- Douglas Adams
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
