Hi,
We can play with the github action to allow merging request after
pipeline checks.
About the license, in maven based projects we can use a maven plugin to
check if the license exist and if the content of the license headers are
correct. It will break the build (github action) if it's not correct.
For merging the PRs, it's up to the committers of a project to be
careful of what they are merging. There is no rules at ASF projects to
control that and it's not the role of the PMCs to do that. When a user
is grant to be a committer of a project, it's because PMCs voted for him
and allow write access to the source code of the project. The only
things we can do to prevent merging source code is to add pipeline to
perform some checks but there are not the same for all projects.
This is also the case when a release is submit for vote, all PMC has to
do the conformity checks to validate the content of the release.
Regards,
François
Le 09/12/2024 à 21:40, PJ Fanning a écrit :
Hi,
Would it be possible to come up with a code of practice detailing basics like:
* required license headers and code style generally
* merging one's own PRs - which is strongly discouraged in most PMCs - eg
https://github.com/apache/openserverless-streamer/pull/2
* allowing some time for PRs to be reviewed
I think it is important for PPMCs to have some written guidelines for how code
is submitted and then committed.
Regards,
PJ
