ayush00git commented on issue #175: URL: https://github.com/apache/openserverless/issues/175#issuecomment-6424421828
Hii, I tried to reproduce this on the current ops (go-git v5.12.0), and ops -update does honor HTTPS_PROXY: - HTTPS_PROXY=http://127.0.0.1:9 (dead port): fails with proxyconnect tcp: dial tcp 127.0.0.1:9: connection refused, so the proxy is used. - With a logging proxy: the clone succeeds and the proxy log shows CONNECT github.com:443 - Full -update including the prerequisite downloads: every host (github.com, release-assets.githubusercontent.com, dl.k8s.io, get.helm.sh, kind.sigs.k8s.io) goes through the proxy. - Only HTTP_PROXY set: ignored for https URLs, which is standard behaviour. Your build ([dc51b9](https://github.com/apache/openserverless-cli/commit/dc51b997d2c71274d1bab6f88aae0fe63ce7e145), or https://github.com/apache/openserverless-cli/releases/tag/v0.1.0-2409121919.dev) used the same go-git version and the same clone/pull code. go-git’s default client uses `http.DefaultTransport`, which reads the proxy env vars, so I don’t think this was a regression that got fixed later. I even tried this version of the cli locally and got the same results. What I could reproduce is a TLS-intercepting proxy whose CA isn’t trusted: it fails with x509: certificate signed by unknown authority, and works with SSL_CERT_FILE=<ca.pem> (Linux only). Most corporate proxies re-sign HTTPS, so this would look like “proxy doesn’t work” even though traffic goes through it. @sciabarracom, could you share the exact error you got? If it’s an x509 error, the fix would be a CA option rather than proxy support. go-git already exposes `CABundle` and `InsecureSkipTLS` on `CloneOptions`/`PullOptions`, so we could add something like `OPS_CA_BUNDLE` / `OPS_INSECURE_TLS` and pass `--cacert` / `-k` to the prerequisite curl calls. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
