On Wed, Jun 01, 2011 at 11:41:52AM -0700, Ethan Jackson wrote: > The translation from ofproto to datapath actions has historically > been fairly naive. Since redundant ODP actions result in more code > execution in the fast path, this patch changes xlate_actions() to > emit the fewest possible ODP actions for a given flow.
It emits fewer ODP actions, anyhow. "fewest" might involve reordering to reduce the number of changes. I like this change. It amounts to a cleanup. The code reads better with it than without it. I don't see any changes for the code itself. I would add a few bits of information to the commit log. First, this is not just theoretical, it actually reduces the number of ODP actions for real flow tables that Nicira's controllers use in practice. Second, there is more than the obvious benefit in the case where packet modification actions follow the last output action: in that case, removing the packet modifications avoids a whole sk_clone() in the fast path. Thanks, Ben. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
