On Mon, Jun 06, 2011 at 06:20:02PM -0700, Jean Tourrilhes wrote:
>       Just for curiosity, I've implemented the patch along the line
> of Ben suggestions, see below. I'm wondering if the compiler is smart
> enough to pack bools, if not, I may use bitfields...

Adding a "bool" there should not increase the size of the structure
since there is already some padding.

Bit-fields usually make code slower since the compiler isn't very good
at optimizing access to them.

Your patch looks good to me.  Ethan, would you mind taking a look too,
since you've been thinking about this?  If it looks good to you then
I'll commit it to master.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to