On Thu, Jun 23, 2011 at 11:42:38AM -0700, Andrew Evans wrote: > On Wed, 2011-06-22 at 10:37 -0700, Ben Pfaff wrote: > > OpenFlow commands have several idiosyncratic fields that are used in some > > cases and ignored in others. Until now, ovs-ofctl has been lax about > > allowing some of them in places where they are ignored. This commit > > tightens the checks to exactly what is allowed. > > This looks good. I didn't verify the legal fields for each action > against the OpenFlow spec, however. > > If the user specifies an invalid field for a given action, they'll get > the "unknown keyword %s" error message, right? I think it would be more > helpful to say that the keyword isn't allowed with that action, but I > guess it would add more code. > > I'm fine with pushing this patch as it stands, though. Thanks.
Error reporting could definitely be incrementally improved. I guess I'll wait to do that, though. Thanks for looking this over. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
