Looks good.
--Justin
On Jul 15, 2011, at 11:25 AM, Ben Pfaff wrote:
> Recently I helped debug a scenario where ovsdb-server connected to a remote
> manager, then ovs-vsctl deleted the remote manager and soon after re-added
> it. The log was difficult to interpret because it showed two successful
> connection attempts to the same remote without showing a reason why the
> connection was dropped in the first place. Adding this log message would
> make it clear that the configuration changed to remove that remote
> connection in the meantime.
> ---
> ovsdb/jsonrpc-server.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/ovsdb/jsonrpc-server.c b/ovsdb/jsonrpc-server.c
> index 1da1578..e999ada 100644
> --- a/ovsdb/jsonrpc-server.c
> +++ b/ovsdb/jsonrpc-server.c
> @@ -141,6 +141,7 @@ ovsdb_jsonrpc_server_set_remotes(struct
> ovsdb_jsonrpc_server *svr,
>
> SHASH_FOR_EACH_SAFE (node, next, &svr->remotes) {
> if (!shash_find(new_remotes, node->name)) {
> + VLOG_INFO("%s: remote deconfigured", node->name);
> ovsdb_jsonrpc_server_del_remote(node);
> }
> }
> --
> 1.7.4.4
>
> _______________________________________________
> dev mailing list
> [email protected]
> http://openvswitch.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
