Looks Fine. Ethan
On Tue, Jul 19, 2011 at 09:17, Ben Pfaff <[email protected]> wrote: > OpenFlow 1.0 doesn't say that the ECN bits in OFPAT_SET_NW_TOS actions must > be zero, but Open vSwitch ODP implementations do require that, so mask off > those bits before storing the nw_tos into the flow. > --- > ofproto/ofproto-dpif.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c > index 228b32c..6c0f0b8 100644 > --- a/ofproto/ofproto-dpif.c > +++ b/ofproto/ofproto-dpif.c > @@ -3107,7 +3107,7 @@ do_xlate_actions(const union ofp_action *in, size_t > n_in, > break; > > case OFPUTIL_OFPAT_SET_NW_TOS: > - ctx->flow.nw_tos = ia->nw_tos.nw_tos; > + ctx->flow.nw_tos = ia->nw_tos.nw_tos & IP_DSCP_MASK; > break; > > case OFPUTIL_OFPAT_SET_TP_SRC: > -- > 1.7.4.4 > > _______________________________________________ > dev mailing list > [email protected] > http://openvswitch.org/mailman/listinfo/dev > _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
