On Thu, Aug 04, 2011 at 02:21:39PM -0700, Casey Barker wrote: > This commit makes several library headers suitable for inclusion in C++. > > It adds [extern "C"] guards and makes minor changes to fix casting and > keyword issues.
Thanks Casey. The extern "C" changes look fine. The changes that add casts to "enum" values look OK too, but I'm sure that I'll come along later and say, hey, why are those casts there, and think about removing them. Would you mind just changing the "enum"s to "const uint32_t"s? Then the casts shouldn't be needed. The changes that replace (void *) casts by more specific casts will actually need to *add* a more specific cast instead of replacing the (void *) cast, because the (void *) cast suppresses a warning about casting to a more strictly aligned pointer type on RISC architectures. Thanks, Ben. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
