I sent some feedback on patches 5 through 8. The others look good to me. Thanks,
Ben. On Fri, Aug 12, 2011 at 11:57:06AM -0700, Ethan Jackson wrote: > Just to be clear, before this is merged I think I need a review on the > following patches. > nx-match: Fix bug in "move" action. > tests: test "load" and "move" actions. > > And the updates to the following patches: > nx-match: New function nxm_read_field_bits(). > nicra-ext: New action NXAST_OUTPUT_REG. > > On Fri, Aug 12, 2011 at 11:52, Ethan Jackson <[email protected]> wrote: > > This series has changed enough that I decided to resend the entire > > thing. ?Pretty much all of this has been reviewed with the > > exception of a new patch "nx-match: Fix bug in "move" action.". ?We > > will likely want to backport that patch to 1.2. > > > > Ethan Jackson (8): > > ?lib: Whitespace cleanup. > > ?tests: Update gitignore. > > ?flow: New FLOW_WC_SEQ build assertion. > > ?nx-match: Fix bug in "move" action. > > ?tests: test "load" and "move" actions. > > ?nx-match: Update register check functions. > > ?nx-match: New function nxm_read_field_bits(). > > ?nicra-ext: New action NXAST_OUTPUT_REG. > > > > ?NEWS ? ? ? ? ? ? ? ? ? ? ? ? ?| ? ?3 + > > ?include/openflow/nicira-ext.h | ? 33 +++++++++++++- > > ?lib/autopath.c ? ? ? ? ? ? ? ?| ? 11 ++++- > > ?lib/bundle.c ? ? ? ? ? ? ? ? ?| ? 11 ++++- > > ?lib/classifier.c ? ? ? ? ? ? ?| ? 12 +++-- > > ?lib/flow.c ? ? ? ? ? ? ? ? ? ?| ? ?4 +- > > ?lib/flow.h ? ? ? ? ? ? ? ? ? ?| ? 14 ++++++ > > ?lib/learning-switch.c ? ? ? ? | ? ?2 +- > > ?lib/multipath.c ? ? ? ? ? ? ? | ? ?7 +++- > > ?lib/netdev.c ? ? ? ? ? ? ? ? ?| ? ?2 +- > > ?lib/nx-match.c ? ? ? ? ? ? ? ?| ?101 > > +++++++++++++++++++++++++---------------- > > ?lib/nx-match.h ? ? ? ? ? ? ? ?| ? ?7 +++- > > ?lib/odp-util.c ? ? ? ? ? ? ? ?| ? ?2 +- > > ?lib/ofp-parse.c ? ? ? ? ? ? ? | ? 24 +++++++++- > > ?lib/ofp-print.c ? ? ? ? ? ? ? | ? ?8 +++ > > ?lib/ofp-util.c ? ? ? ? ? ? ? ?| ? 26 +++++++++++ > > ?lib/ofp-util.h ? ? ? ? ? ? ? ?| ? ?3 +- > > ?lib/util.c ? ? ? ? ? ? ? ? ? ?| ? ?2 +- > > ?ofproto/netflow.c ? ? ? ? ? ? | ? ?2 +- > > ?ofproto/ofproto-dpif.c ? ? ? ?| ? 25 +++++++++- > > ?ofproto/ofproto.c ? ? ? ? ? ? | ? ?4 +- > > ?tests/.gitignore ? ? ? ? ? ? ?| ? ?1 + > > ?tests/ofproto-dpif.at ? ? ? ? | ? 44 ++++++++++++++++++ > > ?tests/ovs-ofctl.at ? ? ? ? ? ?| ? ?2 + > > ?utilities/ovs-ofctl.8.in ? ? ?| ? ?9 +++- > > ?25 files changed, 294 insertions(+), 65 deletions(-) > > > > -- > > 1.7.6 > > > > > _______________________________________________ > dev mailing list > [email protected] > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
