On Fri, Oct 07, 2011 at 01:03:27PM -0700, Pravin B Shelar wrote: > Following match makes necessary changes required in ovs kernel module > to handle new format of actions list passed from user-space. > Validation and execution paths are changed. > > Signed-off-by: Pravin B Shelar <[email protected]> > Bug #7115
> + if (memcmp(eth_hdr(skb)->h_source, eth_key->eth_src, ETH_HLEN)) > + memcpy(eth_hdr(skb)->h_source, eth_key->eth_src, ETH_HLEN); > + if (memcmp(eth_hdr(skb)->h_dest, eth_key->eth_dst, ETH_HLEN)) > + memcpy(eth_hdr(skb)->h_dest, eth_key->eth_dst, ETH_HLEN); Just glancing at this patch, I noticed that you can use compare_ether_addr() here instead of memcmp(). _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
