On Thu, Nov 17, 2011 at 2:17 PM, Pravin B Shelar <pshe...@nicira.com> wrote: > Only tunneling code needs to keep ref to flow structure cached. > But upstream OVS does not have tunneling code. So we can safely > remove flow ref-counting. > > Signed-off-by: Pravin B Shelar <pshe...@nicira.com>
Can you also remove the assignment of OVS_CB(skb)->flow to NULL in vport.c and vport-internal_dev.c since they are no longer used? > diff --git a/net/openvswitch/flow.h b/net/openvswitch/flow.h > index 7d6abc0..8012ac9 100644 > --- a/net/openvswitch/flow.h > +++ b/net/openvswitch/flow.h > @@ -134,9 +131,7 @@ void flow_deferred_free(struct sw_flow *); > struct sw_flow_actions *flow_actions_alloc(const struct nlattr *); > void flow_deferred_free_acts(struct sw_flow_actions *); > > -void flow_hold(struct sw_flow *); > -void flow_put(struct sw_flow *); > - > +void flow_free(struct sw_flow *flow); I think it would be better to group this under flow_deferred_free(). _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
