If a statically defined GRE key is used with checksums then the checksum will overwrite the key. This is because the key is set at header caching time and the checksum is set at packet processing time and we don't update the offset on packet processing because we don't do anything with the key.
Reported-by: Christos Argyropoulos <[email protected]> Signed-off-by: Jesse Gross <[email protected]> --- datapath/vport-gre.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/datapath/vport-gre.c b/datapath/vport-gre.c index 4411cac..eb10009 100644 --- a/datapath/vport-gre.c +++ b/datapath/vport-gre.c @@ -101,10 +101,11 @@ static struct sk_buff *gre_update_header(const struct vport *vport, - GRE_HEADER_SECTION); /* Work backwards over the options so the checksum is last. */ - if (mutable->flags & TNL_F_OUT_KEY_ACTION) { + if (mutable->flags & TNL_F_OUT_KEY_ACTION) *options = be64_get_low32(OVS_CB(skb)->tun_id); + + if (mutable->out_key || mutable->flags & TNL_F_OUT_KEY_ACTION) options--; - } if (mutable->flags & TNL_F_CSUM) *(__sum16 *)options = csum_fold(skb_checksum(skb, -- 1.7.5.4 _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
