On Tue, Jan 31, 2012 at 01:53:49PM -0800, Gurucharan Shetty wrote:
> + case ${OVSDHCPINTERFACES} in
> + ${OVSINTF#ifcfg-} | \
> + "${OVSINTF#ifcfg-},"* | \
> + *",${OVSINTF#ifcfg-}" | \
> + *",${OVSINTF#ifcfg-},"*)
As an Old Fart ;-) I'd want to say, that this could be written
as:
case ",${OVSDHCPINTERFACES}," in
*",${OVSINTF#ifcfg-},"*)
And instead of comma-separated list OVSDHCPINTERFACES could be
space separated list (as in $BOND_IFACES), and instead of
OVSINTF=${CONFIG} we could use OVSINTF=${DEVICE}, this way we
don't need to strip the "ifcfg-" prefix.
I was also thinking about my proposal to specify all Port
configuration in Bridge config file. Advantage of this method is
when you ifup a Bridge, all Ports will be automatically added to
this Bridge. Disadvantage is when you ifdown/ifup a Port, it
will not be added back to Bridge. This could be serious issue
for, like, PPP-based devices. Since current implementation
satisfies everyone, let it be.
--
Regards, --
Sir Raorn. --- http://thousandsofhate.blogspot.com/
signature.asc
Description: Digital signature
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
