Looks good, thanks.

Ethan

On Sun, May 13, 2012 at 4:58 PM, Ben Pfaff <[email protected]> wrote:
> Found by clang.
>
> Signed-off-by: Ben Pfaff <[email protected]>
> ---
>  lib/ofp-print.c       |    2 +-
>  utilities/ovs-vsctl.c |    2 --
>  2 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/lib/ofp-print.c b/lib/ofp-print.c
> index 7479bf2..1757a30 100644
> --- a/lib/ofp-print.c
> +++ b/lib/ofp-print.c
> @@ -480,7 +480,7 @@ ofp_print_bit_names(struct ds *string, uint32_t bits,
>     }
>
>     if (bits) {
> -        if (n++) {
> +        if (n) {
>             ds_put_char(string, ' ');
>         }
>         ds_put_format(string, "0x%"PRIx32, bits);
> diff --git a/utilities/ovs-vsctl.c b/utilities/ovs-vsctl.c
> index 2fc87f0..d8aeb53 100644
> --- a/utilities/ovs-vsctl.c
> +++ b/utilities/ovs-vsctl.c
> @@ -3809,8 +3809,6 @@ do_vsctl(const char *args, struct vsctl_command 
> *commands, size_t n_commands,
>
>         if (ctx.try_again) {
>             vsctl_context_done(&ctx, NULL);
> -
> -            status = TXN_TRY_AGAIN;
>             goto try_again;
>         }
>     }
> --
> 1.7.2.5
>
> _______________________________________________
> dev mailing list
> [email protected]
> http://openvswitch.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to