On 5/25/12 5:31 PM, Jesse Gross wrote:
On Fri, May 25, 2012 at 11:59 AM, Luiz Ozaki<[email protected]> wrote:
On 5/25/12 11:05 AM, Jesse Gross wrote:
No, the caller will perform that check. rpl_skb_gso_segment() is a
compatibility replacement for skb_gso_segment() on older kernels. It needs
to return a pointer, not an error code.
Hmmm... Yea, Im trying to do some debug on this.
I did the objdump, I think I found the line but I got stuck.
<0>EIP: [<f1f0cd29>] queue_userspace_packet+0x19/0x310 [openvswitch_mod]
SS:ESP 0069:ef935af4
I don't think that looking at assembler dumps is the best way to go
about this. The original poster also mentioned that he saw this with
the Linux bridge so if you're looking at the same thing then OVS code
is probably not the issue.
Sweet !
[ovs-dev] [PATCH] datapath: Check correct return value from
skb_gso_segment()
This patch seems to fix this kernel crash...
I looked over and over the queue_userspace_packet and I didn't see that
typo error, nice catch !
So far, no crashes.
Tks !
--
Luiz Henrique Ozaki
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
