It's not entirely clear what problem the null interface type is trying to solve, nor how it could be of use to any controller. This patch deprecates it, and schedules its removal for February 2013. If there are concerns, please email [email protected].
Signed-off-by: Ethan Jackson <[email protected]> --- NEWS | 2 ++ vswitchd/bridge.c | 5 +++++ vswitchd/vswitch.xml | 3 ++- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 45e1176..872f8d0 100644 --- a/NEWS +++ b/NEWS @@ -22,6 +22,8 @@ post-v1.8.0 February 2013. Please email [email protected] with concerns. - The autopath action is deprecated and will be removed no earlier than February 2013. Please email [email protected] with concerns. + - The null interface type is deprecated and will be removed no earlier + than February 2013. Please email [email protected] with concerns. v1.8.0 - xx xxx xxxx diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index 1fbbe32..6eb525e 100644 --- a/vswitchd/bridge.c +++ b/vswitchd/bridge.c @@ -2527,6 +2527,11 @@ bridge_add_del_ports(struct bridge *br, iface->type = type; } else if (strcmp(type, "null")) { bridge_queue_if_cfg(br, cfg, port); + } else { + VLOG_WARN_ONCE("%s: The null interface type is deprecated and" + " may be removed in February 2013. Please email" + " [email protected] with concerns.", + cfg->name); } } } diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index b71a308..a1b99f8 100644 --- a/vswitchd/vswitch.xml +++ b/vswitchd/vswitch.xml @@ -1215,7 +1215,8 @@ </dd> <dt><code>null</code></dt> - <dd>An ignored interface.</dd> + <dd>An ignored interface. Deprecated and slated for removal in + February 2013.</dd> </dl> </column> </group> -- 1.7.11.4 _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
