On Aug 29, 2012, at 2:51 AM, Joe Stringer <[email protected]> wrote:

> Other parts of OVS have moved on since the tcpdump patch was created. This
> commit brings the patch up to date to work with the current codebase,  and
> will compile cleanly on newer tcpdump.

In the commit message, can you indicate what version of tcpdump is "current"? 

> +     print-timed.c print-tipc.c print-token.c print-udld.c print-udp.c \
> +     print-usb.c print-vjc.c print-vqp.c print-vrrp.c print-vtp.c \
> +-    print-wb.c print-zephyr.c signature.c setsignal.c tcpdump.c util.c
> ++    print-wb.c print-zephyr.c signature.c setsignal.c tcpdump.c util.c 
> print-openflow.c

It might be nice to keep this to 80 columns.

Otherwise, it looks good to me.  Thanks for updating it.

--Justin


_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to