On Thu, Sep 13, 2012 at 01:41:04PM +0900, Isaku Yamahata wrote: > On Wed, Sep 12, 2012 at 08:56:41PM -0700, Ben Pfaff wrote: > > On Thu, Sep 13, 2012 at 11:30:23AM +0900, Isaku Yamahata wrote: > > > From: Isaku Yamahata <[email protected]> > > > Date: Mon, 10 Sep 2012 18:21:20 +0900 > > > Subject: [PATCH] python/ovs/db/idl.py: Transaction._substitute doesn't > > > handle list/tuple > > > > > > Since Transaction._substitute doesn't substitute elements of list/tuple, > > > setting list references results in transaction error. Teach it such case. > > > > That's a bad bug, and I'm surprised that we haven't caught it before. > > But I think that there is still a bug: the C version of > > substitute_uuids(), in ovsdb-idl.c, also recurses through JSON objects. > > Doesn't the Python version need to, similarly, recurse through Python > > dictionaries? > > No. Python dictionary isn't passed because JSON map/set are represented > as python list. Please refer to Datum.to_json. Not Datum.to_python. > JSON map is represented as > ["map", [['key0': value0], ['key2': value2] ...]] > > JSON set is represented as > ["set", [value0, value1, ...]] > > Here's updated one according to Reid comment.
Thanks, applied to master. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
