On Wed, 26 Sep 2012 16:34:35 -0700
Pravin B Shelar <[email protected]> wrote:

>  
> +int gre_add_protocol_v0(const struct gre_protocol_v0 *proto, u8 priority)
> +{
> +     if (priority >= GREPROTO_V0_MAX)
> +             goto err_out;
> +
> +     spin_lock(&gre_proto_lock)

You don't need another lock for this. Protocols should be only
registered with RTNL held. Put ASSERT_RTNL() here for safety.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to