On Oct 17, 2012, at 1:53 PM, Pravin Shelar <pshe...@nicira.com> wrote: > On Wed, Oct 17, 2012 at 7:00 AM, Kyle Mestery (kmestery) > <kmest...@cisco.com> wrote: >> On Oct 14, 2012, at 8:41 PM, Pravin B Shelar <pshe...@nicira.com> wrote: >>> This patch was posted by Kyle. I fixed few issues found in earlier >>> version. >>> >>> V7: >>> - Fix according to comments posted on V6. >>> V6: >>> - Fix more comments addressed from Jesse. >>> V5: >>> - Address another round of comments from Jesse. >>> V4: >>> - Address 2 comments from Jesse: >>> - When processing actions, if OVS_CB(skb)->tun_key is NULL, point it at one >>> on the stack temporarily. This goes away when we remove the ability to set >>> tun_id outside the scope of tun_key. >>> - Move tun_key to the end of struct sw_flow_key. >>> V3: >>> - Fix issues found during review by Jesse. >>> - Add a NEWS entry around tunnel code no longer assuming symmetric input and >>> output tunnel keys. >>> >>> V2: >>> - Fix blank line addition/removal found by Simon. >>> - Fix hex printing output found by Simon. >> >> >> Pravin: >> >> Can you comment if the main changes you made to my patch are around handling >> tunnel configuration per-flow instead of per-port? I looked at that part >> specifically, >> and it appears you made changes similar to what I had been making and was >> going >> to resubmit later this week. Other than this, did you make any other >> changes? I didn't >> look closer at the rest of the patch, but it appears to be mostly my stock >> patch. >> > Hi Kyle, > > Most of changes are related to comments I posted earlier. > Got it. Sorry it took me so long to post the patches, I had actually addressed those as well.
>> If the above is true: >> >> Acked-by: Kyle Mestery <kmest...@cisco.com> >> >> Also, I'll rework the second patch in my series later this week once I'm >> back from >> traveling and repost that one. >> > Are you talking about key-optimization patch? Do you see a problem > with approach I have taken? > I am reviewing that now. > Thanks, > Pravin. > >> Thanks, >> Kyle _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
