On Jan 25, 2013, at 3:21 PM, Ben Pfaff <[email protected]> wrote: > @@ -4858,6 +4858,7 @@ oftable_replace_rule(struct rule *rule) > > victim = rule_from_cls_rule(classifier_replace(&table->cls, &rule->cr)); > if (victim) { > + list_remove(&victim->expirable);
In oftable_remove_rule(), there's a check whether the list is empty before removing it. While it doesn't really matter, it might be nice to keep them looking consistent. Otherwise, looks good. --Justin _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
