Getting rid of mostly dummy function parameters and duplication is always nice, but I'd like it better if there was a way not to have to see the "md." everywhere (start to miss C++ here..). Also, since we care about the zeros at the end of struct flow, maybe we should have them in struct flow_tnl and struct flow_metadata as well?
Jarno On May 11, 2013, at 2:42 , ext Ben Pfaff wrote: > The "struct flow_metadata" is only used in a few specific places > currently, but it can be generalized and used more broadly. This > series does that. > > The first three patches seem quite reasonable and low-impact to me: > flow: Use struct flow_tnl in struct flow_metadata. > flow: Extend flow_metadata member 'in_port' from 16 to 32 bits. > flow: Add skb_priority and skb_mark to struct flow_metadata. > > The remaining two patches are more likely to prompt a reaction. I > am curious to see what that reaction is: > flow: Use struct flow_metadata inside struct flow. > flow: Make flow_extract()'s caller responsible for metadata. > > lib/cfm.c | 4 +- > lib/dpif-netdev.c | 15 +++--- > lib/flow.c | 34 ++----------- > lib/flow.h | 51 ++++++++----------- > lib/learning-switch.c | 14 +++--- > lib/match.c | 122 ++++++++++++++++++++++---------------------- > lib/meta-flow.c | 72 +++++++++++++------------- > lib/nx-match.c | 17 ++++--- > lib/odp-util.c | 44 ++++++++-------- > lib/ofp-parse.c | 6 +-- > lib/ofp-print.c | 17 ++++--- > lib/ofp-util.c | 64 +++++++++++++----------- > ofproto/netflow.c | 4 +- > ofproto/ofproto-dpif.c | 128 +++++++++++++++++++++++++---------------------- > ofproto/ofproto.c | 6 ++- > ofproto/tunnel.c | 32 ++++++------ > ofproto/tunnel.h | 2 +- > tests/test-bundle.c | 8 +-- > tests/test-classifier.c | 58 ++++++++++----------- > tests/test-flows.c | 5 +- > tests/test-multipath.c | 6 +-- > tests/test-odp.c | 2 +- > 22 files changed, 350 insertions(+), 361 deletions(-) > > -- > 1.7.10.4 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
