Thanks for the contribution! I have some comments.
"git am" reported some trailing whitespace:
Applying: ofctl: Initial attempt for multiple tables in replace-flows
/home/blp/ovs/.git/rebase-apply/patch:50: trailing whitespace.
table_classifiers_find_classifier(struct table_classifiers *tcls,
/home/blp/ovs/.git/rebase-apply/patch:55: trailing whitespace.
HMAP_FOR_EACH_IN_BUCKET(cls_node, hmap_node, table_id_hash(table_id),
/home/blp/ovs/.git/rebase-apply/patch:68: trailing whitespace.
hmap_insert(&tcls->classifiers, &cls_node->hmap_node,
/home/blp/ovs/.git/rebase-apply/patch:135: trailing whitespace.
enum ofputil_protocol protocol, struct list *packets,
warning: 4 lines add whitespace errors.
Why is it necessary to modify ofputil_flow_dump_protocols?
It would be nice to add a test for this functionality in
tests/ovs-ofctl.at, so that we can ensure that it works and that it
does not regress.
GCC reported some issues that made me not look farther for now:
cc1: warnings being treated as errors
../utilities/ovs-ofctl.c: In function ‘read_flows_from_source’:
../utilities/ovs-ofctl.c:2190: error: passing argument 2 of
‘read_flows_from_file’ from incompatible pointer type
../utilities/ovs-ofctl.c:1946: note: expected ‘struct table_classifiers *’
but argument is of type ‘struct classifier *’
../utilities/ovs-ofctl.c:2197: error: passing argument 3 of
‘read_flows_from_switch’ from incompatible pointer type
../utilities/ovs-ofctl.c:2053: note: expected ‘struct table_classifiers *’
but argument is of type ‘struct classifier *’
If you'll send a v2 that fixes these errors, I'll continue reviewing.
Thanks,
Ben.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
