We will continue to allow missing eth_type in the netlink attribute to imply Ethernet II type. 802.3 frames requires a specific eth_type attribute.
With Mega flows, we further require a missing eth_type in the key attribute to have a exact match (oxffff) in the eth_type of the mask attribute (if present). In this patch, dpctl will output eth_type(0/0xffff) to indicate mssing eth_type key attribute with a exact match mask, and corresponding parsing logic to support this special case. IMHO, it will be better to be able to drop the '0' in the output (e.g. eth_type(/0xffff)). I plan to address this when we change how odp parser away from using sscanf(). Other suggestions are welcome. Please let me know if you need more information. --andy On Wed, Jun 19, 2013 at 10:20 AM, Ben Pfaff <[email protected]> wrote: > On Tue, Jun 18, 2013 at 04:15:10PM -0700, Andy Zhou wrote: > > Added support to allow mega flow specified and displayed. ovs-dpctl tool > > is mainly used as debugging tool. > > > > This patch also implements the low level user space routines to send > > and receive mega flow netlink messages. Those netlink suppor > > routines are required for forthcoming user space mega flow patches. > > > > Added a unit test to test parsing and display of mega flows. > > > > Ethan contributed the ovs-dpctl mega flow output function. > > > > Co-authored-by: Ethan Jackson <[email protected]> > > Signed-off-by: Ethan Jackson <[email protected]> > > Signed-off-by: Andy Zhou <[email protected]> > > I know there was an offline discussion of how to handle eth_type and > specifically its absence when Ethernet II is not in use. I wasn't > there for that discussion, can you explain the conclusions? >
_______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
