Currently, we are calling guarded_list_destroy()
to destroy a mutex and then go ahead and use it through
delete_group
->delete_group__
->handle_flow_mod__
->run_rule_executes
->guarded_list_pop_all
The group related unit tests cause ovs-vswitchd to crash
because of this (on windows).
Calling guarded_list_destroy() after delete_group() solves the
problem.
Signed-off-by: Gurucharan Shetty <[email protected]>
---
ofproto/ofproto.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index f16005c..6c6399e 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -1310,9 +1310,9 @@ ofproto_destroy__(struct ofproto *ofproto)
ovs_assert(list_is_empty(&ofproto->pending));
destroy_rule_executes(ofproto);
- guarded_list_destroy(&ofproto->rule_executes);
-
delete_group(ofproto, OFPG_ALL);
+
+ guarded_list_destroy(&ofproto->rule_executes);
ovs_rwlock_destroy(&ofproto->groups_rwlock);
hmap_destroy(&ofproto->groups);
--
1.7.9.5
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
